Skip to content

Make Step 2's KB duplicate search visible with a printed log line - #25

Merged
bguidolim merged 2 commits into
mainfrom
copilot/fix-duplicate-search-gate
Aug 28, 2026
Merged

Make Step 2's KB duplicate search visible with a printed log line#25
bguidolim merged 2 commits into
mainfrom
copilot/fix-duplicate-search-gate

Conversation

Copilot AI commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Step 2 of the continuous-learning capture skill decides whether a session skips, edits, or creates a memory based on a knowledge-base search — but unlike Step 4's pre-Write checks, it never required printed output. A search that never ran was indistinguishable from one that ran and found nothing, weakening the audit trail behind the duplication (C.2) and narrow-learning (H) DROP categories.

Changes

  • skills/continuous-learning/SKILL.md — Step 2 now requires one printed line recording the search and the branch taken, before continuing to Step 3:
KB search: "<query>" -> <n> hits, <what they covered> -> <branch taken, and the file edited or created>

This mirrors the existing rationale for Step 4's visible checks ("Hidden reasoning is easy to skip; printed output is reviewable") and adds no new mechanism — just makes an already-mandatory step auditable.

Co-authored-by: bguidolim <987360+bguidolim@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix capture skill's duplicate search enforcement Make Step 2's KB duplicate search visible with a printed log line Aug 27, 2026
Copilot AI requested a review from bguidolim August 27, 2026 23:54
@bguidolim
bguidolim marked this pull request as ready for review August 27, 2026 23:56
@bguidolim
bguidolim requested a lite review from Copilot August 27, 2026 23:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the continuous-learning capture skill to make Step 2’s knowledge-base duplicate search auditable by requiring a single printed log line that records the search and the chosen branch (skip/edit/create), aligning Step 2 with Step 4’s “visible checks” rationale from Issue #22.

Changes:

  • Add a Step 2 requirement to print one log line summarizing the KB search and the decision branch taken.
  • Provide a concrete example format for that log line in the skill instructions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Print one line recording this search before continuing, matching the Step 4 checks — hidden reasoning is easy to skip, printed output is reviewable:

```
KB search: "<query>" -> <n> hits, <what they covered> -> <branch taken, and the file edited or created>
@bguidolim
bguidolim merged commit 78fee39 into main Aug 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The capture skill's duplicate search is its least-enforced gate

3 participants